add a new workflow task failure cause for workflow pause#821
Merged
Conversation
spkane31
force-pushed
the
spk/fail-not-started-wft
branch
from
d9e4cab to
6c16e49
Compare
yuandrew
reviewed
Jul 10, 2026
| WORKFLOW_TASK_FAILED_CAUSE_EXTERNAL_STORAGE_FAILURE = 38; | ||
| // A workflow task is failed because the workflow is paused before the task is started. | ||
| WORKFLOW_TASK_FAILED_CAUSE_NOT_STARTED_TASK_PAUSED_WORKFLOW = 39; | ||
| WORKFLOW_TASK_FAILED_CAUSE_WORKFLOW_PAUSE_REQUESTED_BEFORE_TASK_STARTED = 40; |
Contributor
There was a problem hiding this comment.
Is it intentional that there's 2 added here? PR description only mentions WORKFLOW_TASK_FAILED_CAUSE_NOT_STARTED_TASK_PAUSED_WORKFLOW. And they kinda seem like the same error but worded differently?
Contributor
Author
There was a problem hiding this comment.
Fixed. I messed up a previous rebase.
spkane31
force-pushed
the
spk/fail-not-started-wft
branch
from
3f8fcb9 to
feba120
Compare
yuandrew
approved these changes
Jul 10, 2026
yuandrew
left a comment
yuandrew
left a comment
Contributor
There was a problem hiding this comment.
PR description should be updated with the new name
simvlad
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add a new
WorkflowTaskFailedCauseenumWORKFLOW_TASK_FAILED_CAUSE_NOT_STARTED_TASK_PAUSED_WORKFLOWWhy?
A new failure cause when a workflow task is scheduled but never started when a workflow is paused by an operator. The workflow task will be failed with this new cause.
Breaking changes
N/A
Server PR
Not needed